Skip to content

Bump cert-manager release versions#515

Merged
jetstack-bot merged 4 commits intocert-manager:masterfrom
irbekrm:bump_versions
Jun 15, 2021
Merged

Bump cert-manager release versions#515
jetstack-bot merged 4 commits intocert-manager:masterfrom
irbekrm:bump_versions

Conversation

@irbekrm
Copy link
Contributor

@irbekrm irbekrm commented Jun 15, 2021

This PR:

  • bumps cert-manager versions so that release-next is now release-1.5 and release-previous is release-1.4 (See Bump cert-manager version #466 for how this was done last time)
  • makes all periodics against all releases run e2e tests also against k8s v1.21- I think this now makes sense?
  • makes the optional pull-cert-manager-e2e-v1-21-feature-issuers-venafi-tpp test run against k8s v1.21 (change from v1.20)
  • updates a few comments

Do we need to create a release-1.5 branch on cert-manager repo before merging this PR?

irbekrm added 3 commits June 15, 2021 13:50
To include the --jobs flag for Bazel command

Signed-off-by: irbekrm <irbekrm@gmail.com>
Signed-off-by: irbekrm <irbekrm@gmail.com>
Signed-off-by: irbekrm <irbekrm@gmail.com>
@irbekrm irbekrm requested review from jakexks and wallrj June 15, 2021 12:59
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. area/cert-manager Indicates a PR related to cert-manager approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 15, 2021
@irbekrm
Copy link
Contributor Author

irbekrm commented Jun 15, 2021

/release-note-none

@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 15, 2021
Signed-off-by: irbekrm <irbekrm@gmail.com>
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

And thanks for adding those missing parts of the descriptions.

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2021
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 317de89 into cert-manager:master Jun 15, 2021
@jetstack-bot
Copy link
Contributor

@irbekrm: Updated the following 2 configmaps:

  • plugins configmap in namespace default at cluster default using the following files:
    • key plugins.yaml using file config/plugins.yaml
  • job-config configmap in namespace default at cluster default using the following files:
    • key cert-manager-periodics.yaml using file config/jobs/cert-manager/cert-manager-periodics.yaml
    • key cert-manager-presubmits.yaml using file config/jobs/cert-manager/cert-manager-presubmits.yaml
    • key cert-manager-release-next-periodics.yaml using file config/jobs/cert-manager/release-next/cert-manager-release-next-periodics.yaml
    • key cert-manager-release-previous-periodics.yaml using file config/jobs/cert-manager/release-previous/cert-manager-release-previous-periodics.yaml
    • key cert-manager-release-previous-presubmits.yaml using file config/jobs/cert-manager/release-previous/cert-manager-release-previous-presubmits.yaml
Details

In response to this:

This PR:

  • bumps cert-manager versions so that release-next is now release-1.5 and release-previous is release-1.4 (See Bump cert-manager version #466 for how this was done last time)
  • makes all periodics against all releases run e2e tests also against k8s v1.21- I think this now makes sense?
  • makes the optional pull-cert-manager-e2e-v1-21-feature-issuers-venafi-tpp test run against k8s v1.21 (change from v1.20)
  • updates a few comments

Do we need to create a release-1.5 branch on cert-manager repo before merging this PR?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@irbekrm irbekrm deleted the bump_versions branch June 15, 2021 13:24
@maelvls maelvls mentioned this pull request Jun 16, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cert-manager Indicates a PR related to cert-manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants